Refactor handler lifecycle management with timeouts and auto-recovery #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringintech
force-pushed
the
handler-refactor
branch
from
abe8792 to
f90bb4f
Compare
stringintech
force-pushed
the
handler-refactor
branch
from
f90bb4f to
5ff81f7
Compare
Extract handler process management into a separate Handler type with: - Read timeout to prevent hanging on unresponsive handlers - Shutdown with fallback to force-kill on timeout - Automatic handler respawn when broken, allowing remaining tests to continue - Single handler instance reused across test suites
Introduce HandlerConfig struct and refactor NewHandler to support custom args/env. Add TestMain-based re-exec pattern allowing the test binary to serve as both test runner and mock handler subprocess. This enables unit testing of different handler behaviors (normal, crash, hang, unresponsive) without external fixtures, verifying the runner correctly handles each scenario.
Add --handler-timeout flag to runner binary allowing users to configure max response wait time per test case (default: 10s). Add TestHandler_Unresponsive to verify timeout behavior when handler becomes unresponsive.
Adds TestHandler_Crash to verify the runner correctly handles handlers that crash while processing requests. The test confirms ErrHandlerClosed is returned and that panic messages from stderr are captured in the error.
Add --timeout flag (default 30s) to limit total test execution time across all test suites, complementing per-test-case --handler-timeout.
stringintech
force-pushed
the
handler-refactor
branch
from
5ff81f7 to
d6bf3b0
Compare
Owner
Author
|
Rebased and tested new pre-release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors handler process management into a separate Handler type with configurable timeouts and automatic recovery, preventing test suite hangs and enabling reliable execution.
Changes
--handler-timeout(default: 10s): Max wait time for handler response per test case--timeout(default: 30s): Total execution time limit across all test suitesUsage
Testing
Introduces TestMain-based re-exec pattern where the test binary acts as both runner and mock handler subprocess, enabling unit tests for different handler behaviors without external fixtures.
Currently tests cover: