feat: add approval_requests public API endpoints to V2 CLI commands#1542
feat: add approval_requests public API endpoints to V2 CLI commands#1542aditigoyal-stripe merged 5 commits intomasterfrom
Conversation
Adds CLI commands for the 5 publicly documented endpoints from approval_requests_service.proto: list, retrieve, submit, cancel, execute. Skips approve/reject which are documented: INTERNAL. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
vcheung-stripe
left a comment
vcheung-stripe
left a comment
There was a problem hiding this comment.
Nice! I think this is failing CI because these two files (resources_gen.go and specs_gen.go) are expected to be autogenerated from the OpenAPI spec. I'd recommend moving these lines into a different file (somewhere in pkg/cmd/resource/ is probably good), and then updating PostProcessResourceCommands to "patch in" these new commands into the command tree.
Move approval_requests CLI commands out of auto-generated files into a hand-maintained file (pkg/cmd/resource/approval_requests.go) and patch them into the command tree via PostProcessResourceCommands, following the same pattern as events and terminal commands. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
Some test contexts call PostProcessResourceCommands without V2 resources registered, so the core namespace doesn't exist. Match RemoveAppsCmd's pattern of silently returning nil instead of erroring. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
Okay fixed it. |
SubmitApprovalRequestRequest now includes an optional reason field. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
Co-authored-by: Vincent Cheung <71457708+vcheung-stripe@users.noreply.github.com>
2 participants
Adds CLI commands for the 5 publicly documented endpoints from approval_requests_service.proto: list, retrieve, submit, cancel, execute. Skips approve/reject which are documented: INTERNAL.
Committed-By-Agent: claude
Reviewers
r? @
cc @stripe/developer-products
Summary