Skip to content

Comments

add pre-commit hook to run linters#187

Merged
joek-stripe merged 1 commit intostripe:masterfrom
joek-stripe:DX-4734
Sep 19, 2019
Merged

add pre-commit hook to run linters#187
joek-stripe merged 1 commit intostripe:masterfrom
joek-stripe:DX-4734

Conversation

@joek-stripe
Copy link
Contributor

Reviewers

r? @ob-stripe
cc @stripe/dev-platform

Summary

Added a file .pre-commit to our repo that can be manually added to your githooks or automatically via make githooks-init, so when you run git commit our make lint will be run to give you feedback more quickly

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@stripe-ci stripe-ci assigned joek-stripe and unassigned ob-stripe Sep 19, 2019
@joek-stripe joek-stripe merged commit 7b60bb3 into stripe:master Sep 19, 2019
@joek-stripe joek-stripe deleted the DX-4734 branch September 19, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants