Merged
Conversation
ob-stripe
commented
Apr 30, 2020
| binary: stripe | ||
| env: | ||
| - CGO_ENABLED=1 | ||
| - CGO_ENABLED=0 |
Contributor
Author
There was a problem hiding this comment.
Strictly speaking this was all that was needed to fix the issue. The rest is just opportunistic fixes/updates.
tomer-stripe
approved these changes
Apr 30, 2020
|
Seems fine! You might want to take at the failing build in the matrix — I don't think it's related to your change, but it seems like it's possible to get a data race while running the test suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @brandur-stripe @tomer-stripe
cc @stripe/dev-platform
Summary
Fix Docker image.
My change from yesterday to enable cgo (#439) unfortunately broke the Docker image for the CLI, because the Alpine image does not have the required libraries that the cgo-enabled
stripebinary expects.I've fixed this by disabling cgo for Linux, and keeping it enabled for macOS and Windows, and verified that the Docker image works again (by building locally). The main reason we wanted cgo was to fix the DNS issue on macOS anyway.
If it turns out that using cgo for Linux is desirable for some reason, there are a few ways we can enable it: