Retry after socket timeout exceptions, too#1072
Merged
richardm-stripe merged 2 commits intomasterfrom Jul 30, 2020
Merged
Conversation
richardm-stripe
deleted the
richardm-retry-after-sockettimeout-exceptions-too
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1071
Causes HttpClient to retry after both ConnectException and SocketTimeoutException (previously it only retried after ConnectException).
My impression is that
SocketTimeoutExceptionoccurs if a socket has successfully been established, but too much time has elapsed without any bytes being written through it. Whereas 'ConnectException' includes timeouts for the socket becoming established in the first place.r? @ob-stripe
cc @remi-stripe @cjavilla-stripe @stripe/api-libraries