Fix retrieval of upcoming Invoice line items#1087
Merged
matthewling-stripe merged 1 commit intomasterfrom Aug 27, 2020
Merged
Conversation
Some endpoints receive the "root" object id as a query string parameter for example `/v1/invoices/upcoming/lines?customer=cus_xxx` if `invoice.getLines().list(linesParams)` is used. If, in `linesParams`, further options are passed (limit: 5 for example), these are incorrectly appended to the URI using a question mark and not an ampersand, resulting in calls for upcoming line items for a customer specified by a resource ID of cus_xxx?limit=5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some endpoints receive the "root" object id as a query string parameter for example:
/v1/invoices/upcoming/lines?customer=cus_xxxifinvoice.getLines().list(linesParams)is used.If, in
linesParams, further options are passed (limit: 5 for example), these are appended to the URI using a question mark and not an ampersand, resulting in in a URI of the formhttp://api.stripe.com/v1/invoices/upcoming/lines/?customer=cus_xxx?limit=5.This PR attempts to fix this by first checking whether the incoming
specURL has an existing query string. If it does, it appends any further params, specified in the incoming params hash, otherwise appends a new query string starting with ampersand.