Conversation
richardm-stripe
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
Bump ErrorProne to latest version, and fix some new warnings:
protectedconstructors instead ofpublicDateis a bad API that should not be used. I've removed support for it in the encoder entirely since we do not have anyDatefields anyway -- all timestamps are declared asLong. If we do decide to use an actual date-time type in the future, it should beInstantorLocalDaterather thanDateInvalidParamis probably never going to be fixable for us. It complains about the usage of{@code canceled_at}in some docstrings for classes that have acanceledfield because it uses a heuristic and think the docstring is incorrect. Not a big deal, so let's just disable it and move on.MissingSummaryis trivially fixable by adding a summary to the docstring forEventData#getObject(currently defined via an override in autogen)SameNameButDifferentis fixable but would require some work in autogen to use fully-qualified names instead of short names when appropriate. IIRC we already have existing logic for a related case, so it might not be too hard to fix this case as well, but I'll let you decide if it's worth the effort.