Merged
Conversation
richardm-stripe
force-pushed
the
latest-codegen
branch
from
d8660b2 to
6ad8b31
Compare
remi-stripe
requested changes
Feb 20, 2021
| @Getter | ||
| @Setter | ||
| @EqualsAndHashCode(callSuper = false) | ||
| public static class SubscriptionUpdateProduct extends StripeObject { |
Contributor
There was a problem hiding this comment.
This one should be named Product so the client_metadata internally is wrong
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class ConfigurationTest extends BaseStripeTest { | ||
| public static final String SESSION_ID = "bps_123"; |
| @@ -0,0 +1,40 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
We shouldn't add this. stripe-mock should have the right fixtures instead so we should remove and fix the test above
richardm-stripe
commented
Feb 22, 2021
src/test/java/com/stripe/functional/billingportal/ConfigurationTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
r? @remi-stripe
|
remi-stripe
approved these changes
Feb 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codegen for openapi 403fdb8.
r? @richardm-stripe
cc @stripe/api-libraries
Changelog
BillingPortal.Configurationconfigurationandon_behalf_ofonSession#createandBillingPortal.SessionWebhookEndpoint#create.enabled_events[]andWebhookEndpoint#update.enabled_events[]added new enum members:billing_portal.configuration.created and billing_portal.configuration.updated