Merged
Conversation
remi-stripe
requested changes
Jun 29, 2021
|
|
||
| @SerializedName("oxxo") | ||
| PaymentIntent.PaymentMethodOptions.Oxxo oxxo; | ||
|
|
Contributor
There was a problem hiding this comment.
Those two are wrong. This should not be shared with the PaymentIntent class' options. It should be a separate resource internally in pay-server so that when they diverge over time we don't cause breaking changes. This will require changes internally first.
Contributor
Author
There was a problem hiding this comment.
Great catch. Thanks Remi!
…eto and Oxxo objects in Session.PaymentMethodOptions.
dcr-stripe
commented
Jun 29, 2021
Contributor
Author
dcr-stripe
left a comment
dcr-stripe
left a comment
There was a problem hiding this comment.
Thanks @remi-stripe - PTAL?
|
|
||
| @SerializedName("oxxo") | ||
| PaymentIntent.PaymentMethodOptions.Oxxo oxxo; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Great catch. Thanks Remi!
remi-stripe
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codegen for openapi 3237fde.
r? @richardm-stripe
cc @stripe/api-libraries
Changelog
boleto_paymentsonAccount.capabilitiesboletoandoxxoonSessionCreateParamsandSession