Merged
Conversation
richardm-stripe
force-pushed
the
latest-codegen
branch
from
20e2e18 to
13deec9
Compare
Contributor
Author
|
This LGTM now! r? @dcr-stripe |
dcr-stripe
approved these changes
Jul 9, 2021
Contributor
dcr-stripe
left a comment
dcr-stripe
left a comment
There was a problem hiding this comment.
Overall LGTM! Thanks Richard!
| import java.util.Map; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class QuoteTest extends BaseStripeTest { |
Contributor
There was a problem hiding this comment.
Do we want to add tests for Computed?
Contributor
Author
There was a problem hiding this comment.
I've done some testing manually. The fixture that we have from stripe-mock doesn't include line_items, so the regression test wouldn't be a very useful one really.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codegen for openapi 780fbc3.
r? @richardm-stripe
cc @stripe/api-libraries
Changelog
QuotequoteonInvoice