Skip to content

API Updates#1263

Merged
richardm-stripe merged 4 commits intomasterfrom
latest-codegen
Sep 15, 2021
Merged

API Updates#1263
richardm-stripe merged 4 commits intomasterfrom
latest-codegen

Conversation

@richardm-stripe
Copy link
Contributor

Codegen for openapi 95a1ab8.
r? @dcr-stripe
cc @stripe/api-libraries

Changelog

  • Add support for default_for on CheckoutSessionCreateParams.payment_method_options.acss_debit.mandate_options, Checkout.Session.payment_method_options.acss_debit.mandate_options, Mandate.payment_method_details.acss_debit, SetupIntentCreateParams.payment_method_options.acss_debit.mandate_options, SetupIntentUpdateParams.payment_method_options.acss_debit.mandate_options, SetupIntentConfirmParams.payment_method_options.acss_debit.mandate_options, and SetupIntent.payment_method_options.acss_debit.mandate_options
  • Add support for acss_debit on InvoiceCreateParams.payment_settings.payment_method_options, InvoiceUpdateParams.payment_settings.payment_method_options, Invoice.payment_settings.payment_method_options, SubscriptionCreateParams.payment_settings.payment_method_options, SubscriptionUpdateParams.payment_settings.payment_method_options, and Subscription.payment_settings.payment_method_options
  • Add support for new value acss_debit on enums InvoiceCreateParams.payment_settings.payment_method_types[], InvoiceUpdateParams.payment_settings.payment_method_types[], SubscriptionCreateParams.payment_settings.payment_method_types[], and SubscriptionUpdateParams.payment_settings.payment_method_types[]
  • Add support for livemode on Reporting.ReportType

* to pass to invoices created by the subscription.
*/
@SerializedName("acss_debit")
Invoice.PaymentMethodOptions.AcssDebit acssDebit;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to unshare

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richardm-stripe
Copy link
Contributor Author

r? @dcr-stripe I think it's good to go now!

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@EqualsAndHashCode(callSuper = false)
public static class AcssDebit extends StripeObject {
@SerializedName("mandate_options")
AcssDebitMandateOptions mandateOptions;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be called MandateOptions with no prefix

@EqualsAndHashCode(callSuper = false)
public static class AcssDebit extends StripeObject {
@SerializedName("mandate_options")
AcssDebitMandateOptions mandateOptions;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@richardm-stripe
Copy link
Contributor Author

r? @remi-stripe I think this is ready now

@richardm-stripe richardm-stripe merged commit 0f5b744 into master Sep 15, 2021
@richardm-stripe richardm-stripe deleted the latest-codegen branch September 15, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants