⚠️ Make RequestOptions & RawRequestOptions constructors private and add Stripe-Request-Trigger header#2172
Merged
mbroshi-stripe merged 8 commits intomasterfrom Mar 18, 2026
Merged
Conversation
xavdid-stripe
commented
Mar 5, 2026
xavdid-stripe
requested review from
mbroshi-stripe and
prathmesh-stripe
and removed request for
a team and
prathmesh-stripe
mbroshi-stripe
approved these changes
Mar 5, 2026
Member
Author
|
Going to hold on this PR for ~ 2 weeks until we can make breaking changes. Work tracked in DEVSDK-3018 |
xavdid-stripe
changed the title
RequestOptions & RawRequestOptions constructors private and add Stripe-Request-Trigger header
Member
Author
|
Claude did some fairly heavy refactoring, but given that the constructors are private now and all the tests pass, I feel decent about it. Would love a second look though! |
mbroshi-stripe
approved these changes
Mar 18, 2026
Contributor
mbroshi-stripe
left a comment
mbroshi-stripe
left a comment
There was a problem hiding this comment.
Looks good! I'll have to refactor #2182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
We're working on surfacing more information to users around what their integration does when handling events. The first step of this is to tie subsequent API requests to the act of event processing. This PR adds a header to do just that.
As part of this work, we made the options constructors private, like they should have been all along. Users should go through the builders to create these.
What?
preparerecipe to justfile to aid automationStripe-Request-Triggerheader in event helpersSee Also