Skip to content

UpdateParams: setters for string properties now all accept EmptyParam#852

Merged
ob-stripe merged 2 commits intomasterfrom
richardm-emptyable-strings
Oct 8, 2019
Merged

UpdateParams: setters for string properties now all accept EmptyParam#852
ob-stripe merged 2 commits intomasterfrom
richardm-emptyable-strings

Conversation

@richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Oct 8, 2019

r? ob-stripe

@richardm-stripe richardm-stripe changed the title UpdateParams: setters for string properties now all accept EmptyParams UpdateParams: setters for string properties now all accept EmptyParam Oct 8, 2019
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I added a small test for good measure

@ob-stripe ob-stripe merged commit 99381d4 into master Oct 8, 2019
@ob-stripe ob-stripe deleted the richardm-emptyable-strings branch October 8, 2019 20:54
@ob-stripe
Copy link
Contributor

Released as 12.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants