Codegen for openapi 28a5c69 + new API version#886
Merged
remi-stripe merged 1 commit intomasterfrom Nov 6, 2019
Merged
Conversation
brandur-stripe
approved these changes
Nov 6, 2019
Contributor
brandur-stripe
left a comment
brandur-stripe
left a comment
There was a problem hiding this comment.
Left a minor comment, but seems okay to me.
| @Setter(lombok.AccessLevel.NONE) | ||
| ExpandableField<PaymentSource> defaultSource; | ||
| @SerializedName("default_settings") | ||
| DefaultSettings defaultSettings; |
Contributor
There was a problem hiding this comment.
I notice that a lot of fields in this file seem to have a docblock, in case you want to add one.
Contributor
Author
There was a problem hiding this comment.
yeah it's autogen-ed from the spec so not something I should add manually. But nice catch, I'll get the team to fix it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to the latest API version and add new changes
2019-11-05default_settingsonSubscritionSchedulebilling_thresholdsandcollection_method,default_payment_methoddefault_sourceandinvoice_settingsfrom `SubscriptionSchedule.chargefilter when listingDispute.r? @ob-stripe
cc @stripe/api-libraries