Conversation
ob-stripe
force-pushed
the
ob-fix-connection-reuse
branch
from
3108606 to
14b44d6
Compare
brandur-stripe
approved these changes
Apr 6, 2020
Contributor
brandur-stripe
left a comment
brandur-stripe
left a comment
There was a problem hiding this comment.
Looks reasonable to me! Thanks for the code simplification too. Nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @richardm-stripe
cc @stripe/api-libraries
This PR should improve connection reuse in stripe-java. It does two things:
the response stream is now closed after we're done reading from it. This is one the recommendations laid out in https://docs.oracle.com/javase/8/docs/technotes/guides/net/http-keepalive.html.
conn.disconnect()is no longer called. The documentation forHttpURLConnection.disconnect()is as unclear as can be, but after reading multiple SO questions and blog posts, my understanding is that callingdisconnect()"hints" that the underlying socket can be closed. For our case I think is unnecessary, we can leave the socket open and the JVM will close it if idles for a long time.