update extensibility SDK name in comments#2633
Conversation
There was a problem hiding this comment.
We should change this entirely. Since we're vendoring the code copied from that SDK, examples should be written to be relative to this SDK and not the other one.
E,.g
* ```ts
* declare module '@stripe/apps-extensibility-sdk/stdlib' {
* interface DecimalRoundingPresets {
* 'my-custom-preset': DecimalRoundingOptions;
* }
* }
*
should actually be something like
* ```ts
* declare module 'stripe' {
* interface DecimalRoundingPresets {
* 'my-custom-preset': DecimalRoundingOptions;
* }
* }
*
|
Fair, i've updated! I've updated the docs so that they work, but i'm a little concerned that we're not exporting the things the doc expects. For instance, you can't type something as a Do we need to update our exports? |
| * | ||
| * @example | ||
| * ```ts | ||
| * import { Decimal, RoundDirection } from '@stripe/apps-extensibility-sdk/stdlib'; |
There was a problem hiding this comment.
This wouldn't have worked - everything is imported under the root Stripe namespace
My understanding was that if exported but not as a type, you can do anything with it (i.e. its only restricted if its a type export). I'll confirm. |
You are in fact correct. I'll put up a PR. |
|
You're welcome to take this one over! It came in as a run ticket so I was grabbing, but you seem to have a lot more context |
…omments Delete the declaration-merging example and import example that referenced the old `@stripe/apps-extensibility-sdk/stdlib` module name. These comments are no longer accurate now that Decimal lives in `stripe`. Folds in the intent of #2633 (which renamed the references); the resolution is to remove the comments entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
|
Folded into #2634 — the stale |
Why?
The Stripe Apps team asked that we update the name of their SDK in our comments
What?
See Also
RUN_DEVSDK-2299