fix(ios): Remove spurious onExit firing during Connect onboarding identity verification#2447
Merged
Merged
Conversation
…ntity verification ASWebAuthenticationSession presenting over the fullScreen modal triggered viewWillDisappear with isBeingDismissed=true, causing the exit chain to fire mid-flow. Since .fullScreen prevents swipe-to-dismiss, the close button is the only valid user exit path — the viewWillDisappear handler was unnecessary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
raksingh-stripe
approved these changes
May 11, 2026
asendra-stripe
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
viewWillDisappear/isBeingDismissedhandler fromConnectAccountOnboardingViewController. It was causing spuriousonExitevents whenASWebAuthenticationSession(e.g. identity verification) presented over the Connect onboarding modal.The video shows that
onExitis being triggered in two situations:ASWebAuthenticationSessionScreen.Recording.2026-05-11.at.10.53.14.mov
Motivation
On iOS, when
ASWebAuthenticationSessionpresents its Safari view controller over the fullScreen modal, UIKit callsviewWillDisappearand reportsisBeingDismissed = true— even though the user didn't close anything. This triggered the full exit chain mid-flow, dismissing the modal unexpectedly. Android is unaffected because it doesn't use this pattern.Since the modal uses
.fullScreenpresentation (which disables swipe-to-dismiss), the close button is the only valid user exit path — theviewWillDisappearhandler was unnecessary.Fixes RUN_MXMOBILE-16445.
Testing
Documentation
Select one: