update token#173
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions Docker image publishing workflow to use a different Docker Hub token secret for authentication.
Changes:
- Switch Docker Hub login from
secrets.DOCKERHUB_TOKENtosecrets.DOCKERHUB_TOKEN_SDBin the Docker image workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with: | ||
| username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN_SDB }} |
There was a problem hiding this comment.
This workflow now references secrets.DOCKERHUB_TOKEN_SDB. If that secret isn’t configured in the repo/org secrets, the Docker Hub login step will fail at runtime. Consider either (a) adding a short inline comment here documenting the required secret name and purpose, or (b) supporting a temporary fallback to the previous secret name during the transition to avoid breaking builds if the secret hasn’t been created everywhere yet.
Suggested change
| password: ${{ secrets.DOCKERHUB_TOKEN_SDB }} | |
| password: ${{ secrets.DOCKERHUB_TOKEN_SDB }} | |
| # Requires DOCKERHUB_TOKEN_SDB secret: Docker Hub access token for pushing stripe/sdb images |
tonyxiao
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How to test (optional)
Related