Skip to content

Set api_version when creating webhooks in stripe accounts#350

Merged
tonyxiao merged 1 commit into
mainfrom
sgresh/api-version
Apr 28, 2026
Merged

Set api_version when creating webhooks in stripe accounts#350
tonyxiao merged 1 commit into
mainfrom
sgresh/api-version

Conversation

@sgresh-stripe
Copy link
Copy Markdown

Summary

We are creating webhooks in the users stripe account w/o setting the API version of the webhook itself: https://docs.stripe.com/api/webhook_endpoints/create?lang=curl#create_webhook_endpoint-api_version

This means we can have webhooks sending payloads to sync-engine in an API version that doesn't match the synced data.

How to test (optional)

Related

  • Closes #

Thanks for contributing ❤️

@sgresh-stripe sgresh-stripe marked this pull request as ready for review April 28, 2026 22:14
Copy link
Copy Markdown
Collaborator

@tonyxiao tonyxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claude go add a test

@tonyxiao tonyxiao merged commit d77349c into main Apr 28, 2026
20 checks passed
@tonyxiao tonyxiao deleted the sgresh/api-version branch April 28, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants