fix: proxy sync-openapi GitHub fetches on v2#185
Merged
kdhillon-stripe merged 3 commits intov2from Mar 28, 2026
Merged
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
This was referenced Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@stripe/sync-openapithrough a proxy-aware transport helper@stripe/sync-openapi(buildListFn/buildRetrieveFn) through the same proxy-aware transportNO_PROXYand localhost/private IP bypasses work correctlysource-stripe, including externalbase_urloverridesWhy
On
v2, there were still a few runtime egress gaps even after the earlier proxy work:@stripe/sync-openapistill used rawfetch(...)for GitHub OpenAPI resolution@stripe/sync-openapialso used rawfetch(...)for the dynamic Stripe API list/retrieve path thatsource-stripebuilds its registry fromNO_PROXY/ localhost behavior could be wrongnew WebSocket(...)connection was still directThis PR closes those service/runtime gaps for the Node-based
v2path used bysync-engine-srv.Non-goals
I did not change separate runtime contexts that are not part of the Node service path:
apps/visualizerapps/supabaseThose may need their own proxy strategy if they are ever run in a similarly restricted environment.
Test plan
pnpm --filter @stripe/sync-protocol buildpnpm --filter @stripe/sync-openapi buildpnpm --filter @stripe/sync-source-stripe buildNO_PROXY/ localhost targets bypass the proxyvitestremains flaky in this shell becauseesbuildis stopping before assertions run, so I did not treat that as signal for or against this patch