This repository was archived by the owner on Apr 25, 2025. It is now read-only.
[wip] Revert "Override common dimensions with signalfx_vary_key_by (#780)" #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-stripe
force-pushed
the
aditya-780
branch
from
dadde28 to
f83c2c2
Compare
Contributor
Author
|
Rebased onto #811 (which we expect to merge into master shortly) |
This reverts commit 532b017.
aditya-stripe
force-pushed
the
aditya-780
branch
from
f83c2c2 to
3f8b380
Compare
Contributor
Author
|
Rebased back onto master, now that the aforementioned branch has been merged |
Contributor
|
Superceded by #814 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 532b017.
This PR should not be merged; I'm opening a PR for it simply as a placeholder for tracking the branch.
#780 updates Veneur to attribute SignalFX API tokens (and therefore metrics) on a per-host basis. That behavior is semantically and logically correct. However, because of the SignalFX billing bug, it's useful to have a branch that tracks a version of Veneur without those changes, in order to facilitate deployment of a patch for billing purposes.
Summary
Motivation
Test plan
Rollout/monitoring/revert plan