fix: docker run port mapping — map nginx port 80, not internal 9010#20
Conversation
The Dockerfile binds CXDB_HTTP_BIND to 127.0.0.1:9010 (internal only) and serves the UI and API via nginx on port 80. The docker run examples mapped host 9010 to container 9010, which hit the internal-only Rust HTTP server and returned empty responses. Docker-compose files are unaffected since they override CXDB_HTTP_BIND to 0.0.0.0:9010.
There was a problem hiding this comment.
Pull request overview
Updates Docker run documentation to correctly publish the container’s nginx port (80) to the host’s expected UI/API port (9010), aligning the docs with the runtime networking model (nginx on :80 proxying to the internal Rust HTTP gateway on 127.0.0.1:9010).
Changes:
- Fix
docker runexamples to map-p 9010:80(instead of-p 9010:9010) in docs and README. - Clarify in getting-started docs that the UI + HTTP API are served via nginx on host
:9010. - Add a new
.gitleaks.tomlallowlisting two commits (not mentioned in PR description).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/getting-started.md | Updates docker run port mapping and clarifies UI/API exposure via nginx. |
| docs/deployment.md | Fixes the Docker quick-start port mapping to publish nginx (:80). |
| README.md | Updates quick-start and local-image docker run examples to map 9010:80. |
| .gitleaks.toml | Adds a gitleaks allowlist for two commits (scope not described in PR). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [allowlist] | ||
| commits = [ | ||
| "38b97de31c16d5bdbc928b028af39293c4086d26", | ||
| "a6eaf775b453dd9776a786a01326c26bc9604b24", | ||
| ] |
There was a problem hiding this comment.
This PR adds a new .gitleaks.toml with an allowlist for two specific commits, but the PR title/description only mentions Docker port-mapping documentation fixes. Please either (a) remove this file from the PR, or (b) update the PR description to explain why these commits must be allowlisted and confirm they do not contain unresolved secret findings (since allowlisting commits can mask real leaks going forward).
3cab403 to
20d4585
Compare
Summary
docker runexamples in README.md, docs/getting-started.md, and docs/deployment.md to use-p 9010:80instead of-p 9010:9010127.0.0.1:9010(internal only). The old mapping causedERR_EMPTY_RESPONSEwhen accessinglocalhost:9010CXDB_HTTP_BIND=0.0.0.0:9010Test plan
docker run -p 9009:9009 -p 9010:80 -v $(pwd)/data:/data cxdb:latestserves the UI athttp://localhost:9010(HTTP 200)curl http://localhost:9010/v1/contexts