fix: return error frames instead of dropping connection on store errors#22
Merged
jmccarthy merged 2 commits intostrongdm:mainfrom Feb 24, 2026
Merged
Conversation
GetBlob, GetHead, and PutBlob handlers used ? on store operations, which propagated errors out of handle_client() and dropped the TCP connection. This violated the protocol spec (docs/protocol.md s7) which requires a 404 ERROR frame for blob not found. Changed store operation errors to flow into the response match so the error-frame builder (map_error + encode_error) handles them. Go client additions: - GetBlob implementation (Client + ReconnectingClient) - ErrBlobNotFound sentinel error - Unit tests with mock TCP server (fs_test.go) - cxdb-blob-verify CLI tool for live server validation - get_blob protocol fixture
Adds a boolean Synthetic field to UserInput for marking programmatically
injected messages (e.g., from navigators or orchestrators) vs direct human
input. UIs may render synthetic inputs differently (dimmed, different icon).
This is a simpler alternative to a separate SteeringMessage type - all
steering/injection use cases can use UserInput{Synthetic: true}.
jmccarthy
approved these changes
Feb 24, 2026
jmccarthy
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetBlob, GetHead, and PutBlob handlers used
?on store operations, which propagated errors out ofhandle_client()and dropped the TCP connection. This violated the protocol spec (docs/protocol.md §7) which requires a 404 ERROR frame for blob not found.Changes
Server (Rust):
map_error+encode_error) handles them properlyGo Client:
GetBlobimplementation forClientandReconnectingClientErrBlobNotFoundsentinel errorfs_test.go)cxdb-blob-verifyCLI tool for live server validationget_blobprotocol fixtureTesting
cxdb-blob-verifytool includes a "connection survives not-found" test that confirms the fix works end-to-end