res.sendFile does not invoke callback for aborted requests.

[manuelstofer]

I added two currently failing tests for cases where sendFile fails to invoke the callback.

[manuelstofer]

It's debatable if aborts are errors.

The current documentation is:

The callback fn(err) is invoked when the transfer is complete or when an error occurs

Not invoking the callback at all would actually be correct if aborts are not counted as errors. But it's unexpected behaviour.

I agree that an abort is not necessarily an error on http request level (for requests without body). But i think it is an error in sendFiles context, because it prevents it from "completing the transfer".

So I'm not sure if i should pass an error to the callback if the request is aborted.

[manuelstofer]

But anyway, the purpose of this pull request is not to change the thing about the aborts, so i removed the abort errors. This pull request just ensures that the callback is always invoked.

[manuelstofer]

@dougwilson
There were commits removed from master? Should i removed them from the pull request too?

[dougwilson]

There were commits removed from master?

Oh, so the repo was not correctly up to date for a while (it was my fault :( ). That was it getting back in sync.

Should i removed them from the pull request too?

Up to you, but it's not necessary.

[dougwilson]

@manuelstofer can you try out the 4.9 branch to see if your issue has been resolved? npm install strongloop/express#4.9 will grab the code to test.

[manuelstofer]

Works great!

[dougwilson]

Awesome, thanks for the confirmation, @manuelstofer , I appreciate it!