fix/update-to-promise-support #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannyHou
force-pushed
the
fix/update-to-promise-support
branch
from
62d9de2 to
6c7d471
Compare
| * @param {Object} modelDefinition The model which has the relation | ||
| * @param {String} name The user input | ||
| * @param {Function(String|Boolean)} Callback to receive the check result. | ||
| * @returns {String|Boolean} Return the check result. |
Member
There was a problem hiding this comment.
Please add @promise annotation for strong-docs tooling.
Contributor
Author
There was a problem hiding this comment.
@bajtos hmm...i might be wrong, but I think the return value is not a promise, it's just a pure String/Boolean value right?
Member
There was a problem hiding this comment.
My understanding is that returning a promise (instead of calling a callback) is the whole point of this patch/change, isn't it?
In the code, you do return getAsync().then(..), which returns a promise. You are returning a boolean/string from inside the function passed to then, but that return value is wrapped in a promise for you.
jannyHou
force-pushed
the
fix/update-to-promise-support
branch
from
9be1557 to
c55f803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect to strongloop/loopback#2292
Contains relation generator fix only.
yeoman-environmentuses the latestinquirer, which depends on a new modulerxthat supports promise only. So we cannot use callback in functioncheckRelationNamePlease review. Thanks.