Skip to content
This repository was archived by the owner on Mar 13, 2020. It is now read-only.

Conversation

@jannyHou
Copy link
Contributor

@jannyHou jannyHou commented May 21, 2019

Description

To do

  • The tests in packages/* should not run
  • Enable travis tests for the experimental branch for PR test: add test folder #9
  • Generate API docs for experimental packages

Demo PR

PR from experimental-dev/passport-strategy to experimental/passport-strategy:
#7,
#8

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@emonddr
Copy link
Contributor

emonddr commented May 22, 2019

@jannyHou
Should this be cherry-pick instead of check-pick?
fd8d0d0#diff-6ff67c3c80ff6c12f0e3ef8f788ea4afL83

image

@jannyHou
Copy link
Contributor Author

Appreciate all the review and discussion. I am closing it since we decide to use loopback-next branches as the lab branch. The latest progress update is in loopbackio/loopback-next#2676 (comment)

@jannyHou jannyHou closed this May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants