fix(repository): change parameter order in HasManyRepositoryFactory

BREAKING CHANGE: the generic SourceID for type HasManyRepositoryFactory
has been renamed to ForeignKeyType and switched with Target generic.
Also, the function createHasManyRepositoryFactory also renames the same
generic and makes it the last declared generic. Lastly, the generic
ForeignKeyType is added to DefaultCrudRepository#_createHasManyRepository
FactoryFor function. Assuming there is an Order and Customer model defined,
see the following examples for upgrade instructions:

For `HasManyRepository` type:

```diff
- public orders: HasManyRepository<typeof Customer.prototype.id, Order>
+ public orders: HasManyRepository<Order, typeof Customer.prototype.id>
```

For `createHasManyRepositoryFactory` function:

```diff
- const orderFactoryFn = createHasManyRepositoryFactory<typeof Customer.
prototype.id, Order, typeof Order.prototype.id>(...);
+ const orderFactoryFn = createHasManyRepositoryFactory<Order, typeof Order.
prototype.id, typeof Customer.prototype.id>(...);
```

Author: biniam

docs/site/HasMany-relation.md

@@ -128,7 +128,7 @@ class CustomerRepository extends DefaultCrudRepository<
   Customer,
   typeof Customer.prototype.id
 > {
-  public orders: HasManyRepositoryFactory<typeof Customer.prototype.id, Order>;
+  public orders: HasManyRepositoryFactory<Order, typeof Customer.prototype.id>;
   constructor(
     @inject('datasources.db') protected db: juggler.DataSource,
     @repository(OrderRepository) orderRepository: OrderRepository,

packages/repository/src/repositories/legacy-juggler-bridge.ts

@@ -132,7 +132,7 @@ export class DefaultCrudRepository<T extends Entity, ID>
    *   Customer,
    *   typeof Customer.prototype.id
    * > {
-   *   public orders: HasManyRepositoryFactory<typeof Customer.prototype.id, Order>;
+   *   public orders: HasManyRepositoryFactory<Order, typeof Customer.prototype.id>;
    *
    *   constructor(
    *     protected db: juggler.DataSource,
@@ -150,12 +150,16 @@ export class DefaultCrudRepository<T extends Entity, ID>
    * @param relationName Name of the relation defined on the source model
    * @param targetRepo Target repository instance
    */
-  protected _createHasManyRepositoryFactoryFor<Target extends Entity, TargetID>(
+  protected _createHasManyRepositoryFactoryFor<
+    Target extends Entity,
+    TargetID,
+    ForeignKeyType
+  >(
     relationName: string,
     targetRepo: EntityCrudRepository<Target, TargetID>,
-  ): HasManyRepositoryFactory<ID, Target> {
+  ): HasManyRepositoryFactory<Target, ForeignKeyType> {
     const meta = this.entityClass.definition.relations[relationName];
-    return createHasManyRepositoryFactory<ID, Target, TargetID>(
+    return createHasManyRepositoryFactory<Target, TargetID, ForeignKeyType>(
       meta as HasManyDefinition,
       targetRepo,
     );

packages/repository/src/repositories/relation.factory.ts

@@ -11,8 +11,8 @@ import {
   DefaultHasManyEntityCrudRepository,
 } from './relation.repository';
 
-export type HasManyRepositoryFactory<SourceID, Target extends Entity> = (
-  fkValue: SourceID,
+export type HasManyRepositoryFactory<Target extends Entity, ForeignKeyType> = (
+  fkValue: ForeignKeyType,
 ) => HasManyRepository<Target>;
 
 /**
@@ -29,14 +29,14 @@ export type HasManyRepositoryFactory<SourceID, Target extends Entity> = (
  * the given target repository
  */
 export function createHasManyRepositoryFactory<
-  SourceID,
   Target extends Entity,
-  TargetID
+  TargetID,
+  ForeignKeyType
 >(
   relationMetadata: HasManyDefinition,
   targetRepository: EntityCrudRepository<Target, TargetID>,
-): HasManyRepositoryFactory<SourceID, Target> {
-  return function(fkValue: SourceID) {
+): HasManyRepositoryFactory<Target, ForeignKeyType> {
+  return function(fkValue: ForeignKeyType) {
     const fkName = relationMetadata.keyTo;
     if (!fkName) {
       throw new Error(

packages/repository/test/acceptance/has-many-without-di.relation.acceptance.ts

@@ -133,8 +133,8 @@ describe('HasMany relation', () => {
     typeof Customer.prototype.id
   > {
     public orders: HasManyRepositoryFactory<
-      typeof Customer.prototype.id,
-      Order
+      Order,
+      typeof Customer.prototype.id
     >;
 
     constructor(

packages/repository/test/acceptance/has-many.relation.acceptance.ts

@@ -205,8 +205,8 @@ describe('HasMany relation', () => {
     typeof Customer.prototype.id
   > {
     public orders: HasManyRepositoryFactory<
-      typeof Customer.prototype.id,
-      Order
+      Order,
+      typeof Customer.prototype.id
     >;
     constructor(
       @inject('datasources.db') protected db: juggler.DataSource,

packages/repository/test/integration/repositories/relation.factory.integration.ts

@@ -28,12 +28,12 @@ describe('HasMany relation', () => {
   let reviewRepo: EntityCrudRepository<Review, typeof Review.prototype.id>;
   let customerOrderRepo: HasManyRepository<Order>;
   let customerAuthoredReviewFactoryFn: HasManyRepositoryFactory<
-    typeof Customer.prototype.id,
-    Review
+    Review,
+    typeof Customer.prototype.id
   >;
   let customerApprovedReviewFactoryFn: HasManyRepositoryFactory<
-    typeof Customer.prototype.id,
-    Review
+    Review,
+    typeof Customer.prototype.id
   >;
   let existingCustomerId: number;
 
@@ -209,9 +209,9 @@ describe('HasMany relation', () => {
 
   function givenConstrainedRepositories() {
     const orderFactoryFn = createHasManyRepositoryFactory<
-      typeof Customer.prototype.id,
       Order,
-      typeof Order.prototype.id
+      typeof Order.prototype.id,
+      typeof Customer.prototype.id
     >(Customer.definition.relations.orders as HasManyDefinition, orderRepo);
 
     customerOrderRepo = orderFactoryFn(existingCustomerId);