feat(testlab): set port to 0 in givenHttpServerConfig

Modify the test helper `givenHttpServerConfig` to explicitly set
the port to zero. With this change in place, applications can use
this helper in acceptation tests without having to explicitly
specify `{port: 0}` to override RestServer's default port 3000.

Author: bajtos

examples/hello-world/test/acceptance/application.acceptance.ts

@@ -31,9 +31,7 @@ describe('Application', () => {
 
   function givenAnApplication() {
     app = new HelloWorldApplication({
-      rest: givenHttpServerConfig({
-        port: 0,
-      }),
+      rest: givenHttpServerConfig(),
       disableConsoleLog: true,
     });
   }

examples/todo-list/test/acceptance/todo-list-todo.acceptance.ts

@@ -124,9 +124,7 @@ describe('TodoListApplication', () => {
 
   async function givenRunningApplicationWithCustomConfiguration() {
     app = new TodoListApplication({
-      rest: givenHttpServerConfig({
-        port: 0,
-      }),
+      rest: givenHttpServerConfig(),
     });
 
     await app.boot();

examples/todo-list/test/acceptance/todo-list.acceptance.ts

@@ -145,9 +145,7 @@ describe('TodoListApplication', () => {
 
   async function givenRunningApplicationWithCustomConfiguration() {
     app = new TodoListApplication({
-      rest: givenHttpServerConfig({
-        port: 0,
-      }),
+      rest: givenHttpServerConfig(),
     });
 
     await app.boot();

examples/todo-list/test/acceptance/todo.acceptance.ts

@@ -143,9 +143,7 @@ describe('TodoListApplication', () => {
 
   async function givenRunningApplicationWithCustomConfiguration() {
     app = new TodoListApplication({
-      rest: givenHttpServerConfig({
-        port: 0,
-      }),
+      rest: givenHttpServerConfig(),
     });
 
     await app.boot();

examples/todo/test/acceptance/todo.acceptance.ts

@@ -175,9 +175,7 @@ describe('TodoApplication', () => {
 
   async function givenRunningApplicationWithCustomConfiguration() {
     app = new TodoListApplication({
-      rest: givenHttpServerConfig({
-        port: 0,
-      }),
+      rest: givenHttpServerConfig(),
     });
 
     await app.boot();

packages/boot/test/acceptance/controller.booter.acceptance.ts

@@ -41,7 +41,7 @@ describe('controller booter acceptance tests', () => {
 
     const MyApp = require(resolve(SANDBOX_PATH, 'application.js')).BooterApp;
     app = new MyApp({
-      rest: givenHttpServerConfig({port: 0}),
+      rest: givenHttpServerConfig(),
     });
   }
 

packages/cli/generators/app/templates/test/acceptance/ping.controller.acceptance.ts.ejs

@@ -30,9 +30,7 @@ describe('PingController', () => {
 
   function givenAnApplication() {
     app = new <%= project.applicationName %>({
-      rest: givenHttpServerConfig({
-        port: 0,
-      }),
+      rest: givenHttpServerConfig(),
     });
   }
 });

packages/http-server/test/integration/http-server.integration.ts

@@ -158,9 +158,9 @@ describe('HttpServer (integration)', () => {
   });
 
   it('supports HTTPS protocol with a pfx file', async () => {
-    const options = {usePfx: true};
-    const serverOptions = givenHttpServerConfig();
-    Object.assign(serverOptions, options);
+    const serverOptions = givenHttpServerConfig({
+      usePfx: true,
+    });
     const httpsServer: HttpServer = givenHttpsServer(serverOptions);
     await httpsServer.start();
     const response = await httpsGetAsync(httpsServer.url);

packages/rest/test/acceptance/coercion/coercion.acceptance.ts

@@ -96,7 +96,7 @@ describe('Coercion', () => {
   });
 
   async function givenAClient() {
-    app = new RestApplication({rest: givenHttpServerConfig({port: 0})});
+    app = new RestApplication({rest: givenHttpServerConfig()});
     app.controller(MyController);
     await app.start();
     client = createRestAppClient(app);

packages/rest/test/acceptance/validation/validation.acceptance.ts

@@ -156,7 +156,7 @@ describe('Validation at REST level', () => {
   }
 
   async function givenAnAppAndAClient(controller: ControllerClass) {
-    app = new RestApplication({rest: givenHttpServerConfig({port: 0})});
+    app = new RestApplication({rest: givenHttpServerConfig()});
     app.controller(controller);
     await app.start();