fix: replace gulp-rename with our own implementation

We need to do in-place rename so that the file can be managed by mem-fs
for. The gulp-rename@1.2.3 breaks us as the clone of file object causes
mem-fs-editor to rewrite a file that's already committed.

Author: raymondfeng

packages/cli/generators/app/index.js

@@ -7,7 +7,7 @@
 const ProjectGenerator = require('../../lib/project-generator');
 const utils = require('../../lib/utils');
 
-module.exports = class extends ProjectGenerator {
+module.exports = class AppGenerator extends ProjectGenerator {
   // Note: arguments and options should be defined in the constructor.
   constructor(args, opts) {
     super(args, opts);

packages/cli/generators/extension/index.js

@@ -9,7 +9,7 @@ const utils = require('../../lib/utils');
 
 const ProjectGenerator = require('../../lib/project-generator');
 
-module.exports = class extends ProjectGenerator {
+module.exports = class ExtensionGenerator extends ProjectGenerator {
   // Note: arguments and options should be defined in the constructor.
   constructor(args, opts) {
     super(args, opts);

packages/cli/lib/project-generator.js

@@ -4,7 +4,6 @@
 // License text available at https://opensource.org/licenses/MIT
 
 'use strict';
-const rename = require('gulp-rename');
 const BaseGenerator = require('./base-generator');
 const utils = require('./utils');
 
@@ -61,24 +60,15 @@ module.exports = class ProjectGenerator extends BaseGenerator {
     });
 
     this._setupRenameTransformer();
+    super._setupGenerator();
   }
 
   /**
    * Registers a Transform Stream with Yeoman. Removes `.ejs` extension
    * from files that have it during project generation.
    */
   _setupRenameTransformer() {
-    this.registerTransformStream(
-      rename(function(file) {
-        // extname already contains a leading '.'
-        const fileName = `${file.basename}${file.extname}`;
-        const result = fileName.match(/(.+)(.ts|.json|.js|.md)\.ejs$/);
-        if (result) {
-          file.extname = result[2];
-          file.basename = result[1];
-        }
-      }),
-    );
+    this.registerTransformStream(utils.renameEJS());
   }
 
   setOptions() {

packages/cli/lib/utils.js

@@ -9,6 +9,7 @@ const debug = require('../lib/debug')('utils');
 const fs = require('fs');
 const path = require('path');
 const util = require('util');
+const stream = require('stream');
 var semver = require('semver');
 const regenerate = require('regenerate');
 const _ = require('lodash');
@@ -208,3 +209,29 @@ exports.getDependencies = function() {
   }
   return deps;
 };
+
+/**
+ * Rename EJS files
+ */
+exports.renameEJS = function() {
+  const renameStream = new stream.Transform({objectMode: true});
+
+  renameStream._transform = function(file, enc, callback) {
+    const filePath = file.relative;
+    const dirname = path.dirname(filePath);
+    let extname = path.extname(filePath);
+    let basename = path.basename(filePath, extname);
+
+    // extname already contains a leading '.'
+    const fileName = `${basename}${extname}`;
+    const result = fileName.match(/(.+)(.ts|.json|.js|.md)\.ejs$/);
+    if (result) {
+      extname = result[2];
+      basename = result[1];
+      file.path = path.join(file.base, dirname, basename + extname);
+    }
+    callback(null, file);
+  };
+
+  return renameStream;
+};

packages/cli/package.json

@@ -43,7 +43,6 @@
     "chalk": "^2.3.2",
     "change-case": "^3.0.2",
     "debug": "^3.1.0",
-    "gulp-rename": "^1.2.2",
     "lodash": "^4.17.5",
     "minimist": "^1.2.0",
     "pacote": "^8.1.1",