feat(context): export function to concat the binding key and path #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truongminh
requested review from
bajtos,
kjdelisle and
raymondfeng
as code owners
|
Can one of the admins verify this patch? |
raymondfeng
reviewed
Jan 2, 2018
packages/context/src/binding.ts
Outdated
| * @param path the path | ||
| * | ||
| */ | ||
| static concatKeyAndPath(key: string, path: string) { |
Contributor
There was a problem hiding this comment.
Maybe it's better to name the method as buildKeyWithPath.
Contributor
There was a problem hiding this comment.
Can you refactor some tests to use this method?
Contributor
There was a problem hiding this comment.
@truongminh Ping. Did you see my comments here?
Contributor
Author
There was a problem hiding this comment.
Sorry for my slow response.
I will refactor the code and write some tests for this feature tomorrow.
raymondfeng
approved these changes
Jan 10, 2018
Contributor
|
@truongminh Thank you for the contribution! |
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current rest config key
RestBinding.CONFIGinpackages/rest/keys.tsis defined as${CoreBindings.APPLICATION_CONFIG}#rest.It is safer to use an exported function from
context/bindingwhere both the concatenation and split are implemented.The new key is
export const CONFIG = Binding.concatKeyAndPath (CoreBindings.APPLICATION_CONFIG, rest)