-
Notifications
You must be signed in to change notification settings - Fork 82
Return Date objects from any Angular SDK resource that has a date property #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Date objects from any Angular SDK resource that has a date property #210
Conversation
…call that return Objects or Object Arrays
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
I have signed the CLA, sorry I did not prior to opening this PR. |
|
Thank you for your PR. Could you please create a unit test to verify your changes? |
|
On the CLA page it just shows the "You have signed this CLA" button, I have tried signing out and back in as well as clicking through each of the two agreements shown in the agreements list, both show the same. |
|
I had used a different github account to commit the changes to this PR and that is why the CLA check was failing, fixed now. Let me know, regarding any next steps. |
|
Would really like to see this happen. Would prevent a lot of manual transforms. @scalarsys do you need help with getting the checks fixed? |
|
I removed my old fork and re-did the changes against the latest master, couple failing tests still over @ My Fork Can't work on it anymore this weekend so wanted to push up what I have. |
|
Can one of the admins verify this patch? |
|
This pull request seems rather abandoned to me. If there is anybody willing to take over the work, then please open a new pull request and mention my GH handle in the PR description. |
I took a try at #141 "Auto-convert timestamp/date string attributes to Date objects" using an example provided by @xak2000
Gist of Example
My contribution extends the services template to include the dateTransformer factory from the example. The template then conditionally injects the dateTransformer and adds a transformResponse to each resource that has at least one property that is defined as a date, passing the property name(s) to the transformer.
Concerns:
meta.sharedClass.ctor.definition.rawProperties