Skip to content

Conversation

@scalarsys
Copy link

I took a try at #141 "Auto-convert timestamp/date string attributes to Date objects" using an example provided by @xak2000

Gist of Example

My contribution extends the services template to include the dateTransformer factory from the example. The template then conditionally injects the dateTransformer and adds a transformResponse to each resource that has at least one property that is defined as a date, passing the property name(s) to the transformer.

Concerns:

  • Should there be a switch on the generator or some other backwards compatibility approach
  • Introduces a requirement for lbServices consumers to have lodash and moment
  • Is this the best way to get and array of property definition from within the template meta.sharedClass.ctor.definition.rawProperties

@slnode
Copy link

slnode commented Feb 26, 2016

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@scalarsys scalarsys changed the title Initial push for feature to return Date objects from any Angular SDK … Return Date objects from any Angular SDK resource that has a date property Feb 26, 2016
@scalarsys
Copy link
Author

I have signed the CLA, sorry I did not prior to opening this PR.

@0candy 0candy added the feature label Mar 30, 2016
@0candy
Copy link
Contributor

0candy commented Mar 30, 2016

Thank you for your PR. Could you please create a unit test to verify your changes?
Also, it still seems to not recognized that you have accepted the CLA. Could you please retry it again?
https://cla.strongloop.com/agreements/strongloop/loopback-sdk-angular
Could you also limit your commit message to 50 characters or less? Thanks!

@scalarsys
Copy link
Author

On the CLA page it just shows the "You have signed this CLA" button, I have tried signing out and back in as well as clicking through each of the two agreements shown in the agreements list, both show the same.

@jeff-clegg
Copy link
Contributor

I had used a different github account to commit the changes to this PR and that is why the CLA check was failing, fixed now. Let me know, regarding any next steps.

@charlie-s
Copy link

charlie-s commented Aug 19, 2016

Would really like to see this happen. Would prevent a lot of manual transforms. @scalarsys do you need help with getting the checks fixed?

@scalarsys
Copy link
Author

scalarsys commented Aug 21, 2016

I removed my old fork and re-did the changes against the latest master, couple failing tests still over @ My Fork

Can't work on it anymore this weekend so wanted to push up what I have.

@slnode
Copy link

slnode commented Aug 21, 2016

Can one of the admins verify this patch?

@bajtos
Copy link
Member

bajtos commented Jun 7, 2017

This pull request seems rather abandoned to me. If there is anybody willing to take over the work, then please open a new pull request and mention my GH handle in the PR description.

@bajtos bajtos closed this Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants