Skip to content

Conversation

@drlukeangel
Copy link
Contributor

fixed link to documentation was 2 now 3

Description

fixed link to documentation was 2 now 3

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • [x ] Code conforms with the style
    guide

@drlukeangel drlukeangel requested a review from bajtos as a code owner December 30, 2017 01:44
@slnode
Copy link

slnode commented Dec 30, 2017

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode
Copy link

slnode commented Dec 30, 2017

Can one of the admins verify this patch?

1 similar comment
@slnode
Copy link

slnode commented Dec 30, 2017

Can one of the admins verify this patch?

@bajtos bajtos changed the title updated readme Update link to docs in readme Jan 2, 2018
Fix the link to documentation to point to 3.x docs instead of 2.x.
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch. The code changes are fine, but the commit message is not following our style - we use imperative, not past tense. I fixed the message for you and will land the patch shortly.

@bajtos
Copy link
Member

bajtos commented Jan 2, 2018

@slnode ok to test

@bajtos bajtos merged commit 88c45a6 into strongloop:master Jan 2, 2018
@bajtos
Copy link
Member

bajtos commented Jan 2, 2018

Landed, thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants