Inconsistency findById vs. destroy vs. __destroyById__*

[fabien]

There's an inconsistency in method naming - we have findById, and __destroyById__* for remoting, yet the relation/scope method is called destroy. This method does take an id, though.

[raymondfeng]

PR? :-)

[fabien]

@raymondfeng shall I go ahead and rename destroy to destroyById? I'm afraid of side-effects - anything to watch out for? Actually, this should be fixed over at juggler anyway.

[raymondfeng]

destroy is the method name in Node. Some docs refer to it, for example:

http://docs.strongloop.com/display/LB/HasMany+relations

You can search the references in juggler project.

[fabien]

Hmm... perhaps we should leave this until a major release?