Skip to content

MCP spike#45

Merged
drrrrr900 merged 5 commits intomainfrom
mcp-spike
Mar 4, 2026
Merged

MCP spike#45
drrrrr900 merged 5 commits intomainfrom
mcp-spike

Conversation

@drrrrr900
Copy link
Contributor

feel free do dismember this

@drrrrr900 drrrrr900 requested a review from Cianidos February 25, 2026 07:44
@drrrrr900 drrrrr900 changed the title Mcp spike MCP spike Feb 25, 2026
@yaroher yaroher self-requested a review February 25, 2026 08:11
@yaroher yaroher added the enhancement New feature or request label Feb 25, 2026
@drrrrr900
Copy link
Contributor Author

Added some shortcuts:

image

`stroppy run tpcc` now resolves files through cwd → ~/.stroppy/ → embedded
workloads. Three input modes based on argument format:
- no extension → preset (tpcc → tpcc.ts + tpcc.sql)
- .ts → test script
- .sql or inline SQL → wrap with execute_sql preset

Script and SQL resolve independently, enabling local overrides.
Fixes -- separator parsing bug where k6 args were treated as SQL path.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@drrrrr900
Copy link
Contributor Author

Thank you for the review, I addressed 2 and 3. As for 1 - I think execute_sql is a more descriptive name for this "catch-all-sql-including-inline" test script/config. I believe it should be used for that role instead of test.ts.

@Cianidos
Copy link
Contributor

Cianidos commented Mar 4, 2026

I believe it should be used for that role instead of test.ts.

Please replace execsql with execute_sql entirely since they are now identical.

Also, please consider changing the flow of the inline SQL query case to pass the SQL query directly through an env var like STROPPY_INLINE_SQL, avoiding the creation of an extra SQL file. execute_sql.ts could be updated slightly to conditionally check the env var or file. Alternatively, a separate exec_sql_inline.ts could be introduced.

Remove duplicate execsql/ preset directory and update references
to use execute_sql/ which now serves both file and inline SQL modes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@drrrrr900
Copy link
Contributor Author

execsql was removed.

Regarding inlining - the temp file will be kept. I like having inline SQL contained. File abstraction goes just fine.

@drrrrr900 drrrrr900 merged commit 3772cb5 into main Mar 4, 2026
2 checks passed
@drrrrr900 drrrrr900 deleted the mcp-spike branch March 4, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants