add memset_sanity and build cleanups to enable it #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoisin
reviewed
Jul 31, 2022
| ## Enable hooking of memcpy/memset to detect out of bounds | ||
| ## r/w operations on chunks allocated with IsoAlloc. Does | ||
| ## not require ALLOC_SANITY is enabled. On MacOS you need | ||
| ## to set FORTIFY_SOURCE to 0. Leave these commented if |
Contributor
There was a problem hiding this comment.
FORTIFY_SOURCE=0 is highly problematic, should a bug be opened to tackle this?
Owner
Author
There was a problem hiding this comment.
Yes. Remove it and compile IsoAlloc for MacOS to see the build error. Ideally we should only do this for MacOS where its actually breaking the build. And then probably another bug to figure out why its breaking in the first place.
Contributor
There was a problem hiding this comment.
It still sucks: isoalloc shouldn't disable FORTIFY_SOURCE :/
Owner
Author
There was a problem hiding this comment.
I agree. Just need time to run down why the build is breaking on MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
memset_sanityas first proposed in #114 by @devnexen.Updates the documentation for
make libc_sanity_tests