Conversation
jvoisin
reviewed
Nov 26, 2022
| } | ||
|
|
||
| EXTERNAL_API void iso_alloc_verify_ptr_tag(void *p, iso_alloc_zone_handle *zone) { | ||
| if(zone == NULL) { |
| return _untag_ptr(p, zone); | ||
| } | ||
|
|
||
| EXTERNAL_API void iso_alloc_verify_ptr_tag(void *p, iso_alloc_zone_handle *zone) { |
Contributor
There was a problem hiding this comment.
Shouldn't this be a return if MEMORY_TAGGING isn't set?
Owner
Author
There was a problem hiding this comment.
I keep all the implementation details, include compile time excludes and likely/unlikely macros, to the internal code to keep the interfaces file from getting too complex. It makes it easier for me to reason about the API contracts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the
iso_alloc_verify_ptr_tagfunction so systems with TBI can verify the pointer tag without removing it.