Skip to content

Conversation

@max-models
Copy link
Member

@max-models max-models commented Nov 25, 2025

Solves the following issue(s):

Closes #14

Todo:

  • Update post_processing/orbits/orbits_tools.py to the new .py parameter format
  • Update/remove pproc_struphy.py

@max-models
Copy link
Member Author

Starting point:

❯ ruff check --output-format=concise
doc/conf.py:21:11: F821 Undefined name `__version__`
doc/conf.py:24:11: F821 Undefined name `__version__`
src/struphy/feec/mass.py:3040:54: F821 Undefined name `self`
src/struphy/feec/mass.py:3040:91: F821 Undefined name `self`
src/struphy/feec/mass.py:3040:105: F821 Undefined name `self`
src/struphy/feec/mass.py:3052:37: F821 Undefined name `self`
src/struphy/feec/mass.py:3052:78: F821 Undefined name `self`
src/struphy/feec/mass.py:3053:37: F821 Undefined name `self`
src/struphy/feec/mass.py:3075:45: F821 Undefined name `self`
src/struphy/feec/mass.py:3075:87: F821 Undefined name `self`
src/struphy/feec/mass.py:3075:101: F821 Undefined name `self`
src/struphy/feec/mass.py:3087:45: F821 Undefined name `self`
src/struphy/feec/mass.py:3087:87: F821 Undefined name `self`
src/struphy/feec/mass.py:3087:101: F821 Undefined name `self`
src/struphy/feec/mass.py:3091:45: F821 Undefined name `self`
src/struphy/feec/mass.py:3091:87: F821 Undefined name `self`
src/struphy/feec/mass.py:3091:101: F821 Undefined name `self`
src/struphy/feec/mass.py:3097:45: F821 Undefined name `self`
src/struphy/feec/mass.py:3097:87: F821 Undefined name `self`
src/struphy/feec/mass.py:3097:101: F821 Undefined name `self`
src/struphy/feec/utilities.py:471:64: F821 Undefined name `self`
src/struphy/feec/utilities.py:478:68: F821 Undefined name `self`
src/struphy/feec/utilities.py:479:69: F821 Undefined name `self`
src/struphy/feec/utilities.py:485:64: F821 Undefined name `self`
src/struphy/fields_background/coil_fields/base.py:113:12: F821 Undefined name `pd`
src/struphy/geometry/utilities.py:187:31: F821 Undefined name `r_flux_surface`
src/struphy/models/variables.py:264:138: F821 Undefined name `obj`
src/struphy/models/variables.py:408:138: F821 Undefined name `obj`
src/struphy/pic/accumulation/filter.py:130:21: F821 Undefined name `xp`
src/struphy/pic/accumulation/filter.py:131:21: F821 Undefined name `xp`
src/struphy/pic/accumulation/filter.py:132:21: F821 Undefined name `xp`
src/struphy/pic/accumulation/filter.py:133:21: F821 Undefined name `xp`
src/struphy/pic/accumulation/filter.py:134:21: F821 Undefined name `xp`
src/struphy/pic/accumulation/filter.py:153:17: F821 Undefined name `xp`
src/struphy/pic/accumulation/filter.py:155:35: F821 Undefined name `xp`
src/struphy/pic/accumulation/filter.py:158:14: F821 Undefined name `xp`
src/struphy/pic/accumulation/filter.py:159:14: F821 Undefined name `xp`
src/struphy/pic/accumulation/filter.py:163:24: F821 Undefined name `xp`
src/struphy/pic/accumulation/filter.py:165:24: F821 Undefined name `xp`
src/struphy/post_processing/cprofile_analyser.py:50:21: F821 Undefined name `name_li`
src/struphy/post_processing/cprofile_analyser.py:51:21: F821 Undefined name `name_li`
src/struphy/post_processing/cprofile_analyser.py:52:21: F821 Undefined name `name_li`
src/struphy/post_processing/cprofile_analyser.py:53:21: F821 Undefined name `name_li`
src/struphy/post_processing/cprofile_analyser.py:54:21: F821 Undefined name `name_li`
src/struphy/post_processing/orbits/orbits_tools.py:50:21: F821 Undefined name `setup_domain_and_equil`
src/struphy/post_processing/pproc_struphy.py:158:37: F821 Undefined name `kinetic_species`
src/struphy/post_processing/pproc_struphy.py:170:82: F821 Undefined name `kinetic_kinds`
src/struphy/post_processing/pproc_struphy.py:173:28: F821 Undefined name `kinetic_kinds`
src/struphy/post_processing/pproc_struphy.py:181:20: F821 Undefined name `kinetic_kinds`
src/struphy/propagators/propagators_fields.py:1642:27: F821 Undefined name `pcg`
src/struphy/propagators/propagators_fields.py:8488:28: F821 Undefined name `u`
Found 51 errors.

@max-models
Copy link
Member Author

@spossann Is src/struphy/post_processing/pproc_struphy.py still used? kinetic_species and kinetic_kinds are undefined there.

@max-models
Copy link
Member Author

Current status:

❯ ruff check --output-format=concise
src/struphy/post_processing/orbits/orbits_tools.py:50:21: F821 Undefined name `model`
src/struphy/post_processing/pproc_struphy.py:158:37: F821 Undefined name `kinetic_species`
src/struphy/post_processing/pproc_struphy.py:170:82: F821 Undefined name `kinetic_kinds`
src/struphy/post_processing/pproc_struphy.py:173:28: F821 Undefined name `kinetic_kinds`
src/struphy/post_processing/pproc_struphy.py:181:20: F821 Undefined name `kinetic_kinds`
Found 5 errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined variables

2 participants