Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the “Mock Sign In” flow on the Authentication screen by routing it through the existing AuthenticationStateNotifier sign-in completion path (so it updates current user state and emits the signed-in event, letting AuthenticationPage handle navigation).
Changes:
- Add
mockSignIn()toAuthenticationStateNotifierto run_signInCompletionwithout an upstream auth provider. - Update the “Mock Sign In” button to call
mockSignIn()and remove now-unused navigation/usecase imports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/features/authentication/authentication_state.dart | Adds mockSignIn() that runs the shared sign-in completion flow and emits the signed-in event. |
| lib/features/authentication/authentication_page_content.dart | Rewires the “Mock Sign In” button to use the notifier API instead of directly navigating. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.