Cleanup of some common lints#474
Merged
aqwert merged 13 commits intostryder-dev:masterfrom Mar 7, 2025
Merged
Conversation
added 13 commits
March 6, 2025 13:55
Don't invoke 'print' in production code.
Author
|
Should I add the analysis.yaml file to prevent degrading the lint over time? And also how about an editorconfig + formatting? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following is list of lints that were used for cleanup, using the
dart fix --apply --code=...command one-by-one. I tried to use the most base lints, to include any opinionations. But incase any are still too opinionated, they can be reverted at the the commit leave.Some give 'free-performance' by just using
constwherever applicable. Other add some type-safety.