Skip to content

doc: modified usage in README.md and doc comment#82

Merged
sttk merged 1 commit intomainfrom
modify_usage_in_readme_and_doc_comment
Aug 14, 2025
Merged

doc: modified usage in README.md and doc comment#82
sttk merged 1 commit intomainfrom
modify_usage_in_readme_and_doc_comment

Conversation

@sttk
Copy link
Owner

@sttk sttk commented Aug 14, 2025

Add forgotten code defer data.Close().

@sttk sttk requested a review from Copilot August 14, 2025 12:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the missing defer data.Close() call to code examples in documentation to ensure proper resource cleanup. The change corrects the sample code by adding the deferred Close() call immediately after creating a DataHub instance.

  • Adds defer data.Close() to sample code in both documentation files
  • Ensures proper resource management pattern is demonstrated in examples

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
doc.go Adds defer Close() call to the DataHub usage example in code documentation
README.md Adds defer Close() call to the DataHub usage example in the README

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sttk sttk merged commit 9537527 into main Aug 14, 2025
12 checks passed
@sttk sttk deleted the modify_usage_in_readme_and_doc_comment branch August 14, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants