Fix hardcoded app icon and change name#4
Merged
stuartlangridge merged 2 commits intostuartlangridge:appfrom Jun 1, 2016
HEXcube:patch-1
Merged
Fix hardcoded app icon and change name#4stuartlangridge merged 2 commits intostuartlangridge:appfrom HEXcube:patch-1
stuartlangridge merged 2 commits intostuartlangridge:appfrom
HEXcube:patch-1
Conversation
- Follow freedesktop icon naming specification (http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#guidelines ) - Additional benefit of icon theme compatibility 😄
HEXcube
changed the title
Contributor
Author
|
Okay @stuartlangridge , I've added a new commit changing the name of all icons to |
Contributor
Author
|
@stuartlangridge Thanx for merging my commit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to freedesktop icon naming specification (the standard for Linux desktop), the correct way to declare icon in desktop file is:
Icon=pick-colour-pickerFixing this issue has the additional benefit of adding icon theme compatibility to Pick's desktop entry.☺️ See: What are hardcoded icons? and Foggalong/hardcode-fixer#221
I've also renamed all icons and the desktop file from☺️
picktopick-colour-pickerto be consistent with the Debian package's name.