Skip to content

Feature/extended email validator#1

Merged
jsprds merged 6 commits intomasterfrom
feature/extended-email-validator
Apr 13, 2021
Merged

Feature/extended email validator#1
jsprds merged 6 commits intomasterfrom
feature/extended-email-validator

Conversation

@jsprds
Copy link
Copy Markdown
Contributor

@jsprds jsprds commented Mar 31, 2021

No description provided.

@jsprds jsprds requested a review from DenisValcke March 31, 2021 07:17
@jsprds jsprds self-assigned this Mar 31, 2021
Copy link
Copy Markdown
Contributor

@DenisValcke DenisValcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enige wat ik zou opmerken is dat we misschien beter deze naar een "ngx-forms" package (library) zouden verhuizen omdat we volgens mij nog heel wat dingen in forms gaan kunnen generiek maken.

Heel goed idee wel!

@jsprds
Copy link
Copy Markdown
Contributor Author

jsprds commented Apr 2, 2021

@DenisValcke dat lijkt mij inderdaad geen slecht idee. Ik zal de extra lib opzetten en de validators verplaatsen. :-)

@DenisValcke
Copy link
Copy Markdown
Contributor

Helemaal top.

In de algemene readme van de repo staat een stukje over publishen, mocht het nodig zijn zo meteen. Ik heb het proces stap voor stap uitgeschreven.

@jsprds jsprds requested a review from DenisValcke April 2, 2021 10:54
@jsprds jsprds merged commit a62cd3e into master Apr 13, 2021
IbenTesara pushed a commit that referenced this pull request Dec 9, 2024
…rough-handle-options

feat(rxjs-utils): The catchAndCallTrough operator now has three different handle modes
IbenTesara pushed a commit that referenced this pull request Dec 12, 2024
IbenTesara pushed a commit that referenced this pull request Dec 12, 2024
…rough-handle-options

feat(rxjs-utils): The catchAndCallTrough operator now has three different handle modes
@reunefe reunefe deleted the feature/extended-email-validator branch January 7, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants