Merged
Conversation
IbenTesara
added
publish
WHeirstrate
requested changes
Dec 16, 2024
Contributor
WHeirstrate
left a comment
WHeirstrate
left a comment
There was a problem hiding this comment.
Shouldn't the target branch be feat/ngx-core/149-setup-shared-library instead of master? Now it looks like you try to both release and implement changes.
Contributor
There was a problem hiding this comment.
- Should this markdown file exist?
- If so, should this not add a little more information as to the purpose of these Angular libs? Perhaps a link to the Angular documentation in a setup section?
| "version": "19.0.0", | ||
| "description": "A library of core functionality used by the Studio Hyperdrive NGX packages.", | ||
| "keywords": [ | ||
| "angular" |
Contributor
There was a problem hiding this comment.
Perhaps Studio Hyperdrive, StudioHyperdrive, and ngx-tools could be additional keywords?
Contributor
There was a problem hiding this comment.
Additional thought: maybe ngx-tools can be a keyword of every package as to connect them more easily through npm?
IbenTesara
changed the base branch from
master
to
feat/ngx-core/149-setup-shared-library
IbenTesara
force-pushed
the
release/ngx-core/v19.0.0
branch
from
10d47b2 to
9ccfcb6
Compare
IbenTesara
force-pushed
the
feat/ngx-core/149-setup-shared-library
branch
from
e73af6d to
4d1d7b4
Compare
IbenTesara
force-pushed
the
release/ngx-core/v19.0.0
branch
from
9ccfcb6 to
dd85b93
Compare
WHeirstrate
approved these changes
Dec 16, 2024
IbenTesara
changed the base branch from
feat/ngx-core/149-setup-shared-library
to
master
IbenTesara
force-pushed
the
release/ngx-core/v19.0.0
branch
from
dd85b93 to
bc1af31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release v19.0.0
Requirements