[Feature] Improve services performance#176
Merged
titouanmathis merged 16 commits intodevelopfrom Jan 7, 2022
Merged
Conversation
This is unnecessary work as getters can be overwritten in child classes to achieve the same result.
Codecov Report
@@ Coverage Diff @@
## develop #176 +/- ##
===========================================
- Coverage 99.59% 99.58% -0.01%
===========================================
Files 65 65
Lines 1467 1449 -18
Branches 330 338 +8
===========================================
- Hits 1461 1443 -18
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6ce6fe6 to
4b9cfe3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo
get:...events from the docChangelog
Changed
Removed
get:...events to alter$refs,$options,$servicesand$childrengetters (4e29610)The getters should be overwritten in child classes to alter their value: