Skip to content

[Feature] Improve services performance#176

Merged
titouanmathis merged 16 commits intodevelopfrom
feature/services-performance
Jan 7, 2022
Merged

[Feature] Improve services performance#176
titouanmathis merged 16 commits intodevelopfrom
feature/services-performance

Conversation

@titouanmathis
Copy link
Contributor

@titouanmathis titouanmathis commented Jan 7, 2022

Todo

  • Remove get:... events from the doc

Changelog

Changed

Removed

  • Breaking: Remove get:... events to alter $refs, $options, $services and $children getters (4e29610)

    The getters should be overwritten in child classes to alter their value:

    class Foo extends Base {
      static config = {
        name: 'Foo',
      };
    
      get $refs() {
        const $refs = super.$refs;
        $refs.myCustomRef = document.querySelector('.my-custom-ref');
        return $refs;
      }
    }

@titouanmathis titouanmathis self-assigned this Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #176 (4b9cfe3) into develop (c9fc233) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #176      +/-   ##
===========================================
- Coverage    99.59%   99.58%   -0.01%     
===========================================
  Files           65       65              
  Lines         1467     1449      -18     
  Branches       330      338       +8     
===========================================
- Hits          1461     1443      -18     
  Misses           6        6              
Flag Coverage Δ
unittests 99.58% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/js-toolkit/Base/managers/ServicesManager.js 100.00% <ø> (ø)
packages/js-toolkit/Base/index.js 100.00% <100.00%> (ø)
packages/js-toolkit/services/Service.js 100.00% <100.00%> (ø)
packages/js-toolkit/services/drag.js 100.00% <100.00%> (ø)
packages/js-toolkit/services/key.js 100.00% <100.00%> (ø)
packages/js-toolkit/services/load.js 100.00% <100.00%> (ø)
packages/js-toolkit/services/pointer.js 98.70% <100.00%> (+0.03%) ⬆️
packages/js-toolkit/services/raf.js 100.00% <100.00%> (ø)
packages/js-toolkit/services/resize.js 100.00% <100.00%> (ø)
packages/js-toolkit/services/scroll.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9fc233...4b9cfe3. Read the comment docs.

@titouanmathis titouanmathis force-pushed the feature/services-performance branch from 6ce6fe6 to 4b9cfe3 Compare January 7, 2022 10:45
@titouanmathis titouanmathis merged commit c86f3f5 into develop Jan 7, 2022
@titouanmathis titouanmathis deleted the feature/services-performance branch January 7, 2022 12:06
titouanmathis added a commit that referenced this pull request Jan 8, 2022
v2.0.0-beta.6

Changed
- Improve services performances (#176)
- **Breaking:** Events emitted by a component must be configured (#178)
- Update NPM dependencies (#177)

Removed
- **Breaking:** Remove `get:...` events to alter `$refs`, `$options`, `$services` and `$children` getters (4e29610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant