[Bugfix] Undefined refs and EventsManager#186
Merged
titouanmathis merged 3 commits intodevelopfrom Jan 12, 2022
Merged
Conversation
The `EventsManager` would throw an error while trying to bind and unbind events from refs which were `undefined`.
titouanmathis
force-pushed
the
bugfix/events
branch
from
886b5ac to
dd36c6c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #186 +/- ##
===========================================
+ Coverage 99.33% 99.35% +0.01%
===========================================
Files 65 66 +1
Lines 1507 1549 +42
Branches 362 371 +9
===========================================
+ Hits 1497 1539 +42
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
titouanmathis
changed the title
titouanmathis
added a commit
that referenced
this pull request
Jan 12, 2022
Merged
titouanmathis
added a commit
that referenced
this pull request
Jan 13, 2022
v2.0.0-beta.9 Added - Add easing functions (#184) Fixed - Add support for custom `IntersectionObserver` options for the `withScrolledInView` decorator (#185) - Add missing doc for decorators - Fix a bug where refs could be `undefined` (#183, #186, 9e891bf) - Add a missing event definition (#183, #186, fc8ef57)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Fixed
undefined(Filter out undefined ref and add a warning in the console #183, [Bugfix] Undefined refs and EventsManager #186, 9e891bf)Fix #183