Merged
Conversation
Using the class of a component as a key for the storage of its instance is error prone when working with inheritance, as a component with the same name can be mounted twice on a single element. Switching to using the name of the component will help stabilize this feature and is aligned with the latest evolution towards name based query for components.
It should not always recreate instances for already existing instances.
[Feature] Refactor reference to components' instances on the root element
[Bugfix] Improve instances storage
Update dependency @studiometa/prettier-config to v4.4.0
[Bugfix] Do not drag when touch has multiple touches
…ame-or-selector [Feature] Add support for custom name or selector to register a component
Update devDependencies
Update docs devDependencies
[Feature] Add a `withGroup` decorator
Export Size@studiometa/js-toolkit
Unchanged@studiometa/js-toolkit
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 99.18% 99.19% +0.01%
==========================================
Files 125 127 +2
Lines 4420 4477 +57
Branches 1183 1200 +17
==========================================
+ Hits 4384 4441 +57
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
registerComponenthelper function (#672, 7a51eac1, #676, bf0957cd)withGroupdecorator (#655, ec57d5a4)Fixed
$registerstatic method multiple times (#672, 409115f7)Changed