Watch local dependency sources in dev/watch mode#70
Merged
titouanmathis merged 2 commits intomainfrom Apr 3, 2026
Merged
Conversation
Register local source files as compilation.fileDependencies so webpack triggers rebuilds when they change. Previously, tsdown would compile them once but changes were ignored in dev/watch mode. Co-authored-by: Claude <claude@anthropic.com>
|
Size Change: 0 B Total Size: 49.7 kB ℹ️ View Unchanged
|
Deploying studiometa-playground with
|
| Latest commit: |
b15c196
|
| Status: | ⚡️ Build in progress... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 26.28% 26.81% +0.52%
==========================================
Files 54 54
Lines 970 977 +7
Branches 185 187 +2
==========================================
+ Hits 255 262 +7
Misses 702 702
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Claude <claude@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using local dependencies (with
sourcepointing to local files),PlaygroundDependenciesPlugincompiled them with tsdown during theprocessAssetshook, but never told webpack to watch those source files. Changes to local dependency sources didn't trigger recompilation in dev/watch mode.Fix
Register local source files as
compilation.fileDependenciesin thethisCompilationhook so webpack watches them and triggers rebuilds when they change.Tests
Added 3 new tests covering file watching behavior:
fileDependenciessourceare not added