Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
+ Coverage 83.79% 83.94% +0.15%
==========================================
Files 152 152
Lines 4936 4952 +16
Branches 863 855 -8
==========================================
+ Hits 4136 4157 +21
+ Misses 497 495 -2
+ Partials 303 300 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bencher Report
Introduce `RequestError` and `ExecutionError` as separate base classes for errors, and make `GraphQLError` a `sealed class` to prevent other subclasses. Refactor the list of `ASTNode`s to a single node to be able to include a proper `path` in the response. BREAKING CHANGE: `GraphQLError` can no longer be instantiated or subclassed; users will have to decide for either `RequestError` or `ExecutionError`. BREAKING CHANGE: `GraphQLError` no longer has a list of `ASTNode`s but only a single one. BREAKING CHANGE: `ExecutionException` no longer accepts an `ASTNode` but only an `Execution`. BREAKING CHANGE: `ExecutionException` now requires a node. BREAKING CHANGE: `path` and `locations` keys may now be missing from the error response if no values can be provided.
stuebingerb
force-pushed
the
refactor/rework-graphql-error
branch
from
ec96a05 to
749904e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
RequestErrorandExecutionErroras separate base classes for errors, and makeGraphQLErrorasealed classto prevent other subclasses.Refactor the list of
ASTNodes to a single node to be able to include a properpathin the response.BREAKING CHANGE:
GraphQLErrorcan no longer be instantiated or subclassed; users will have to decide for eitherRequestErrororExecutionError.BREAKING CHANGE:
GraphQLErrorno longer has a list ofASTNodes but only a single one.BREAKING CHANGE:
ExecutionExceptionno longer accepts anASTNodebut only anExecution.BREAKING CHANGE:
ExecutionExceptionnow requires a node.BREAKING CHANGE:
pathandlocationskeys may now be missing from the error response if no values can be provided.