fix(errors): make model_not_supported advice client-neutral#201
Merged
Conversation
The model_not_supported recovery text hardcoded "in Claude Code run /model and pick one", which is wrong for non-Claude-Code clients — it was seen in Claude Desktop, which has no /model command. Lead with the client-agnostic instruction (use the client's model picker, or set the model id explicitly) and keep Claude Code's /model as a parenthetical hint. Also drop the "(see /model)" suffix on the overflow line for the same reason. Behavior/model list unchanged; wording only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
model_not_supportedrecovery message hardcoded "in Claude Code run /model and pick one". This was seen in Claude Desktop — which has no/modelcommand — so the primary instruction is wrong for that client (and any non-Claude-Code client).Fix
Lead with the client-neutral instruction and demote the Claude-Code command to a parenthetical hint:
Also dropped the
(see /model)suffix on the "…and N more" overflow line for the same reason.Wording only — the model list and all matching logic are unchanged.
check:fastgreen;tests/upstream-error-advice.test.tsupdated to assert the client-neutral lead (11 pass).Note
This addresses the misleading text. The separate, larger issue — Claude Desktop's model picker not loading a list at all (suspected Claude Desktop 3P config-path mismatch) — is under investigation and will be its own PR.