💄 Scrollbar colours for Safari and Chrome and 🐛 fix dark epubjs theme#748
Merged
aaronleopold merged 3 commits intostumpapp:breaking/sea-ormfrom Sep 5, 2025
Merged
💄 Scrollbar colours for Safari and Chrome and 🐛 fix dark epubjs theme#748aaronleopold merged 3 commits intostumpapp:breaking/sea-ormfrom
aaronleopold merged 3 commits intostumpapp:breaking/sea-ormfrom
Conversation
Collaborator
|
👋 I'll have time to give your two PRs a review tomorrow |
aaronleopold
approved these changes
Sep 5, 2025
Collaborator
aaronleopold
left a comment
aaronleopold
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes Safari and Chrome scrollbar (background) colours match the theme the same way Firefox does. I hope the implementation is okay. One annoyance is there was no setting to make it even darker when clicked and held (which Firefox does have for scrollbars and I quite like that), but it didn't work that way previously anyways.
Also a fix to make all dark themes use light text.
Note: Chrome does and soon Safari will support the standard
scrollbar-colorsettings but it doesn't have colour change on hover so can't use that.